Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mention #1095

Merged
merged 3 commits into from
May 20, 2024
Merged

fix: mention #1095

merged 3 commits into from
May 20, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented May 18, 2024 •
edited by jira bot

SBISSUE-16032

  • Fix the issue where the mention feature does not work properly in the input component
  • Fix the issue where unnecessary spaces are added between mention texts when editing an already mentioned message

@bang9 bang9 requested a review from chrisallo May 18, 2024 01:44
@bang9 bang9 self-assigned this May 18, 2024
@netlify Netlify
Copy link

netlify bot commented May 18, 2024 •
edited

✅ Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 30c66ac
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/664808eba641700008cd36b1
😎 Deploy Preview https://deploy-preview-1095--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chrisallo
chrisallo approved these changes May 18, 2024
View reviewed changes
Copy link
Collaborator

@chrisallo chrisallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bang9 bang9 merged commit 479c819 into main May 20, 2024
8 checks passed
@bang9 bang9 deleted the fix/mention branch May 20, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisallo chrisallo chrisallo approved these changes

Assignees

@bang9 bang9

Labels
3.14.7
Projects
None yet
Milestone
No milestone
3 participants
@bang9 @chrisallo @HoonBaek