Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump smol_str from 0.2.1 to 0.2.2 #32295

Merged
merged 1 commit into from
May 16, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 15, 2024

Bumps smol_str from 0.2.1 to 0.2.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [smol_str](https://github.com/rust-analyzer/smol_str) from 0.2.1 to 0.2.2.
- [Commits](https://github.com/rust-analyzer/smol_str/commits/v0.2.2)

---
updated-dependencies:
- dependency-name: smol_str
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added A-dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels May 15, 2024
@servo-bot servo-bot enabled auto-merge May 15, 2024 16:32
@servo-bot servo-bot added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@sagudev sagudev added this pull request to the merge queue May 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 16, 2024
@mukilan
Copy link
Member

mukilan commented May 16, 2024

Looks Windows builds are broken:

Run python mach build --locked --release
error: process didn't exit successfully: `crown -vV` (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)
Failed in 0:00:00
Copy-Item: D:\a\_temp\bf221609-ba1c-46c0-8461-b32ff6383dc1.ps1:3

crown executable is not loading correctly.

@sagudev
Copy link
Member

sagudev commented May 16, 2024

Looks Windows builds are broken:

Run python mach build --locked --release
error: process didn't exit successfully: `crown -vV` (exit code: 0xc0000135, STATUS_DLL_NOT_FOUND)
Failed in 0:00:00
Copy-Item: D:\a\_temp\bf221609-ba1c-46c0-8461-b32ff6383dc1.ps1:3

crown executable is not loading correctly.

The problem are newer runner images: 20240421.1.0 works but 20240514.3.0 does not (windows-2022).

@sagudev
Copy link
Member

sagudev commented May 16, 2024

I think it is actions/runner-images#9701.

@sagudev
Copy link
Member

sagudev commented May 16, 2024

All changes https://github.com/actions/runner-images/releases/tag/win22%2F20240514.3, relevant change (I think): https://github.com/actions/runner-images/pull/9819/files, I did try sagudev@60c9727 but no success and I cannot continue investigating this for next 6h, so if anyone wants to work on this in the mean time be my guest.

@sagudev
Copy link
Member

sagudev commented May 16, 2024

IDEA (before I forget it): We can just temporary (or permanently as no code in script crate is platform specific, I think) disable crown on win builds (if it helps anyway)?

@mrobinson
Copy link
Member

I'm not sure what's going on. Even when I reinstall all of the missing x86_64 components this still fails: https://github.com/servo/servo/actions/runs/9110517902/job/25045734807

Perhaps there is another issue with the runner.

@mukilan
Copy link
Member

mukilan commented May 16, 2024

Based on the bug report here, maybe the unversioned components provided by default need to be removed before installing the ones we want?

@sagudev
Copy link
Member

sagudev commented May 16, 2024

Maybe we are missing some runtime deps like vcredist stuff ... Although there is nothing in the notes about it.

@mukilan
Copy link
Member

mukilan commented May 16, 2024

Based on the bug report here, maybe the unversioned components provided by default need to be removed before installing the ones we want?

Hrm, this didn't help https://github.com/servo/servo/actions/runs/9112814364/job/25052864021

@sagudev
Copy link
Member

sagudev commented May 16, 2024

Maybe we are missing some runtime deps like vcredist stuff ... Although there is nothing in the notes about it.

It does not help: https://github.com/sagudev/servo/actions/runs/9114640136/job/25059078360

@sagudev
Copy link
Member

sagudev commented May 16, 2024

@sagudev sagudev added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 735064a May 16, 2024
15 checks passed
@sagudev sagudev deleted the dependabot/cargo/smol_str-0.2.2 branch May 16, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants