feat(Mcap): Add config for media capabilities cache #6615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CeilingFANC
changed the title
|
Incremental code coverage: 50.00% |
avelad
added
type: enhancement
CeilingFANC
changed the title
avelad
changed the title
theodab
requested changes
May 17, 2024
theodab
requested changes
May 17, 2024
CeilingFANC
force-pushed
the
feat/mediaCapabilitiesCache
branch
from
f504712
to
925e454
Compare
theodab
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6219
For drm contents with many variants, calling mediaCapabilities on all variants can take quiet some times. This PR is trying to provide a way to check availability of variants in a performance way, but with potential false positive. It tries to group/cache variants by some enum, contentType and keysystem, and share results to reduce call to calculating input for mediaCapabilities, building cachekey, and calling mediaCapabilities itself.