-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add YunoHost icon #10947
base: develop
Are you sure you want to change the base?
Add YunoHost icon #10947
Conversation
_data/simple-icons.json
Outdated
{ | ||
"title": "YunoHost", | ||
"hex": "000000", | ||
"source": "https://icon.icepanel.io/Technology/svg/Yuno-Host.svg" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is IcePanel an official source for YunoHost? I can't see anything on the homepage to suggest it is.
Looking at Yunohost's own documentation there is an SVG - but it's a horizontal one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, IcePanel is not really an official source for YunoHost. I just thought I could save some work here as on their official website, they just have a png, see https://yunohost.org. As I found the svg on IcePanel which looked fine I didn't want to manually vectorize the png icon from their website.
So, what would be the correct procedure here? Manually vectorize the png from the website or just change the source? Personally, I prefer the compact logo over the horizontal logo from their documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, we'd find an official source (one of their websites, a Wikipedia entry, or a GitHub repo of theirs) and use that as a source. Failing that, we can compare the SVG you've found against the PNG - but the source should really come from the company themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just redid the icon from the official source @Tagadda linked. Thanks for that!
@CodeShakingSheep - please don't feel the need to merge develop into this unless you're making changes locally. Anyone that has left a comment or review gets pinged every time you do that. 😄 |
I updated the icon from the official source. This is how it looks like. Good with you @adamrusted ? |
Issue: closes #10920
Popularity metric:
The Similarwebrank is 269,570. See https://www.similarweb.com/website/yunohost.org
Checklist
_data/simple-icons.json
viewbox
is0 0 24 24
Description
Downloaded icon from https://techicons.dev/icons/yunohost , resized and combined path and rect.