Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a simple example demonstrating how to use cosmic-ray to improve a test suite. #323

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

abingham
Copy link
Contributor

This is a rebasing and simplification of a set of changes by @trbedwards.

@abingham
Copy link
Contributor Author

@trbedwards Can you look this over and let me know if it looks correct to you?

@codecov-io
Copy link

codecov-io commented Nov 27, 2017

Codecov Report

Merging #323 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #323      +/-   ##
=========================================
- Coverage   83.04%   82.8%   -0.25%     
=========================================
  Files          44      44              
  Lines        1280    1291      +11     
  Branches      124     129       +5     
=========================================
+ Hits         1063    1069       +6     
- Misses        200     203       +3     
- Partials       17      19       +2
Flag Coverage Δ
#py34 82.64% <ø> (-0.25%) ⬇️
#py35 82.49% <ø> (-0.25%) ⬇️
#py36 82.49% <ø> (-0.25%) ⬇️
#pynightly 82.49% <ø> (-0.25%) ⬇️
Impacted Files Coverage Δ
cosmic_ray/reporting.py 43.66% <0%> (+1.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b50c91a...bf47739. Read the comment docs.

@@ -0,0 +1,13 @@
# Run the adam tests with unittest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs to get updated?!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this (bowling_game_score_calculator) be in here (this PR) after all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment is cruft; I've removed it.

I think the bowling_game_score_calculator was part of the same documentation effort from the PyCon UK sprint. @trbedwards: was this intended to be in the same PR as simple_math? I may have messed up the rebasing or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants