fix off by 1 error #217
Open
fix off by 1 error #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Interesting. Which OS are you running? Really appreciate gettings PRs, so thanks! |
|
@skanaar I'm on Debian Testing (Trixie) Node v18.19.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and thanks for this great library :)
While playing around with it and creating awesome diagrams
https://forums.civfanatics.com/media/realism-invictus-3-6-tech-tree-flowchart-eras.7107/full
and
https://forums.civfanatics.com/media/realism-invictus-3-6-tech-tree-flowchart.7106/full
I stumbled upon a bug for https://github.com/skanaar/nomnoml#command-line-interface
omits first filename char and program crashes for me.
Here's my proposed fix and have a nice week
midzer