[k8s] Make ingress paths namespace aware #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
approved these changes
Apr 25, 2024
…o k8s_ports_ingress_namespaced # Conflicts: # sky/provision/kubernetes/network.py
|
Updated the PR to latest master and shortened service names - merging now. Tested:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3372. Paths are now of the format
/skypilot/{namespace}/{cluster_name_on_cloud}/{port}to handle clusters having same name but in different namespaces.This change is not backward compatible. Users upgrading to this version will have their previous clusters continue serving at the same endpoints, but running
sky status --endpointsafter this PR will show the new (and incorrect) endpoints for old clusters. Users using LoadBalancer mode (our default) are not affected.Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.py::test_kubernetes_http_server_with_custom_ports --kubernetes