Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] HTTPS example #3380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Mar 28, 2024

Support HTTPS (SSL) Certificate on SkyServe Load Balancer.

When will a user want to update the certificate?
If it is wrong file the LB wont work anyway

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • The example in this PR
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@cblmemo cblmemo force-pushed the serve-https-example-prototype branch from 030f39b to 56f2c04 Compare June 5, 2024 01:47
@cblmemo cblmemo marked this pull request as ready for review June 5, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant