Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PATH Environment Variable in Dockerfile causing build error (#1832) #1837

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rmcc3
Copy link

@rmcc3 rmcc3 commented Jan 15, 2024

Summary

This pull request fixes a syntax error in the Dockerfile related to setting the PATH environment variable. The adjustment ensures proper path resolution, enhancing the reliability of Docker container execution.

Changes

  • Corrected the ENV PATH setting in the Dockerfile.

Details

Previously, the PATH environment variable was set with a misplaced double quote, which could potentially disrupt the correct path resolution for binaries. This has been rectified to ensure smooth operation of the Docker container. The specific change is as follows:

From:

ENV PATH="/opt/venv/bin:"$PATH

To:

ENV PATH="/opt/venv/bin:$PATH"

Impact

This change ensures that the environment variable PATH is correctly set, allowing the system to properly locate and execute necessary binaries. This is a crucial fix for the functionality of Docker containers built using this Dockerfile.

References

Related Issue: Fixes #1832

Testing

✔️ Ensure that the Docker container builds successfully.
✔️ Verify that the PATH environment variable is set correctly within the container.
✔️ Test the execution of binaries located in /opt/venv/bin.

@rmcc3 rmcc3 changed the title Fix PATH Environment Variable in Dockerfile causing build error Fix PATH Environment Variable in Dockerfile causing build error (#1832) Jan 15, 2024
@rmcc3 rmcc3 marked this pull request as draft January 15, 2024 20:05
@rmcc3 rmcc3 marked this pull request as ready for review January 15, 2024 20:07
@Anto5040
Copy link

Anto5040 commented Feb 9, 2024

I still get the same error with the docker build, doesn't seem to fix it:

17.24 Collecting pyyaml<6,>=5.4.1 (from -r requirements.txt (line 26)) 17.25 Downloading PyYAML-5.4.1.tar.gz (175 kB) 17.30 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 175.1/175.1 kB 17.7 MB/s eta 0:00:00 17.54 Installing build dependencies: started 21.15 Installing build dependencies: finished with status 'done' 21.15 Getting requirements to build wheel: started 21.51 Getting requirements to build wheel: finished with status 'error' 21.52 error: subprocess-exited-with-error 21.52 21.52 × Getting requirements to build wheel did not run successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build fails
2 participants