Skip to content
This repository has been archived by the owner on Aug 24, 2019. It is now read-only.

Add ability to specific accessibility on a per-item basis #184

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bvirlet
Copy link

@bvirlet bvirlet commented Oct 17, 2017

We may want to change the accessibility of a given keychain item. However, the only way to do this currently with SAMKeychain is to use the class method [SAMKeychain accessibilityType]. This has two drawbacks:

  • It sets the accessibility type for all the subsequent password saves
  • If you want to change the accessibility type for a single save, you can rely on setting the global accessibility type because it wouldn't be thread-safe.

This PR adds an accessibility field on the SAMKeychainQuery. It doesn't otherwise change the API and stays backward compatible.

@bvirlet
Copy link
Author

bvirlet commented May 15, 2019

Hi everyone. Could this be merged since it has been approved?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants