Fix promotion code batch #5383
Open
Fix promotion code batch #5383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, when the Spree::PromotionCode creation failed, the exception was raised and the job fails with error. This commit rescues the creation exception and remove the failed code from the codes list.
github-actions
bot
added
the
changelog:solidus_core
DanielePalombo
changed the title
tvdeyen
reviewed
Nov 8, 2023
| @@ -39,13 +39,15 @@ def generate_random_codes | |||
| new_codes = Array.new(max_codes_to_generate) { generate_random_code }.uniq | |||
| codes_for_current_batch = get_unique_codes(new_codes) | |||
|
|
|||
| codes_for_current_batch.each do |value| | |||
| codes_for_current_batch = codes_for_current_batch.map do |value| | |||
There was a problem hiding this comment.
collecting results of large code counts can exceed available memory pretty quickly.
jarednorman
requested changes
Nov 13, 2023
Comment on lines
+43
to
+51
| codes_for_current_batch = codes_for_current_batch.map do |value| | ||
| Spree::PromotionCode.create!( | ||
| value: value, | ||
| promotion: promotion, | ||
| promotion_code_batch: promotion_code_batch | ||
| ) | ||
| end | ||
| rescue ActiveRecord::RecordInvalid | ||
| nil | ||
| end.compact |
There was a problem hiding this comment.
To address @tvdeyen's concern, what about something like:
codes_for_current_batch.filter! do |value|
Spree::PromotionCode.create!(
value: value,
promotion: promotion,
promotion_code_batch: promotion_code_batch
)
rescue ActiveRecord::RecordInvalid
false
endThis should maintain the existing performance characteristics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a new promotion with 2.5m new promo codes has created, it just generated about 250k promo codes and then stopped.
The PromotionBatch screen this error: Errored: #<ActiveRecord::RecordInvalid: Validation failed: Value has already been taken>
This PR rescues the exception raised by the Spree::PromotionCode creation and jumps to the next code to save, avoiding stopping the process completely.
The PR also adds the ability to restart the PromotionCodeBatch from the latest PromotionCodes created.
Fixes: #5379
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: