[Admin] Add order shipments component #5514
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerdema
force-pushed
the
rainerd/admin/order-show-shipments
branch
3 times, most recently
from
676e583
to
1bdfbb7
Compare
rainerdema
force-pushed
the
rainerd/admin/order-show-shipments
branch
2 times, most recently
from
1bcc03e
to
44f885b
Compare
rainerdema
force-pushed
the
rainerd/admin/order-show-shipments
branch
from
44f885b
to
4bdd857
Compare
Co-Authored-By: andrea longhi <andrea@spaghetticode.it>
rainerdema
force-pushed
the
rainerd/admin/order-show-shipments
branch
from
4bdd857
to
e1f8c30
Compare
Co-Authored-By: andrea longhi <andrea@spaghetticode.it>
Since these are already set in all other first-level context blocks and they're going to change in order to expose a bug in the target context block, it makes sense to move them there.
Existing specs are reworked and expanded for better coverage and future improvements.
Increasing the amount of items in the shipment and moving only a part of them exposes the bug (see the xit spec).
github-actions
bot
added
the
changelog:solidus_core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current (wip):
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: