Use Null Promotion Configuration in core #5744
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
mamhoff
force-pushed
the
use-null-promo-config
branch
from
09b93ba
to
82c98ae
Compare
github-actions
bot
added
the
changelog:repository
The existing promotion handlers are activated using either `#apply` or `#activate`. The return value `#activate` is usually not read, and is thus not really important, but that of `#apply` must be the handler itself, so that e.g. the adjustments admin has access to any application errors.
The one example here relies on the legacy promo system.
This is only here to facilitate moving from setting the calculatos on the main Spree::Config object to a configuration. That's why it's already deprecated.
We want to use the legacy `Spree::PromotionConfiguration` in the solidus_legacy_promotions test suite.
This one spec should not live here.
mamhoff
force-pushed
the
use-null-promo-config
branch
from
82c98ae
to
636e27b
Compare
github-actions
bot
added
the
changelog:solidus_api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to use the legacy
Spree::PromotionConfigurationin the solidus_legacy_promotions test suite.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: