Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projects): Grayscale mode is added #364 #385 #390

Closed
wants to merge 5 commits into from

Conversation

Li-0221
Copy link
Contributor

@Li-0221 Li-0221 commented Apr 23, 2024

No description provided.

@Azir-11
Copy link
Member

Azir-11 commented Apr 23, 2024

1、dark模式和grey模式貌似不冲突吧
2、i18n有所缺失

@Li-0221
Copy link
Contributor Author

Li-0221 commented Apr 23, 2024

1、dark模式和grey模式貌似不冲突吧 2、i18n有所缺失

image
不冲突 只是提成了一个方法

@Li-0221
Copy link
Contributor Author

Li-0221 commented Apr 23, 2024

add i18n

@honghuangdc
Copy link
Member

  1. 新增的grayscale是个计算属性,不应该直接v-model
  2. 新增的灰度模式不要和themeSchema混合在一起,就单独提供一个 settings里面的变量即可

@honghuangdc
Copy link
Member

另外,晚上,我创建一个 v1.1的分支,然后你再合并到这个分支之上

@honghuangdc
Copy link
Member

分支已创建 v1.1.0

然后把这两次提交合并成一次提交

从v1.1.0 分支作为起点提交,如果本地代码没有远程新,用git rebase 进行合并

@honghuangdc
Copy link
Member

重新创建 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants