Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL proof of concept (WIP) #5193

Closed
wants to merge 7 commits into from
Closed

GraphQL proof of concept (WIP) #5193

wants to merge 7 commits into from
+2,267 −23

Conversation

lrettig
Copy link
Member

@lrettig lrettig commented Oct 24, 2023

Motivation

spacemeshos/pm#269

Changes

  • pulls in graphQL API from go-ethereum
  • removes irrelevant/unnecessary schemas
  • updates graphQL implementation to use spacemesh schema and types
  • adds an API "backend" interface (for now used only by graphql but could be used by rpc in future)
  • minimally refactors some existing grpc API code around these changes

Test Plan

Imported code includes lots of tests. These still need to be updated.

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

@fasmat fasmat closed this May 23, 2024
@fasmat fasmat deleted the graphql branch May 23, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak will be requested when the pull request is marked ready for review dshulyak is a code owner

@fasmat fasmat Awaiting requested review from fasmat fasmat will be requested when the pull request is marked ready for review fasmat is a code owner

@poszu poszu Awaiting requested review from poszu poszu will be requested when the pull request is marked ready for review poszu is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th will be requested when the pull request is marked ready for review ivan4th is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lrettig @fasmat