-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add hole punching info and data transfer stats #5792
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5792 +/- ##
=========================================
+ Coverage 80.5% 80.6% +0.1%
=========================================
Files 286 287 +1
Lines 29537 29838 +301
=========================================
+ Hits 23784 24066 +282
- Misses 4155 4166 +11
- Partials 1598 1606 +8 ☔ View full report in Codecov by Sentry. |
bors try |
tryBuild failed: |
Partition test flake:
|
bors try |
tryBuild succeeded: |
3934e9d
to
c451fae
Compare
This includes connection kind (relay / hole punching information) and client/server request and transfer statistics.
d5317c3
to
88ed2e8
Compare
Motivation
Current
AdminService.PeerInfoStream
doesn't provide enough information about whether hole punching was used while connecting to a particular peer, and also doesn't reflect actual utilization of each peer, which makes it harder to see whether the peer connections are being used efficiently.Also, importantly, in case if
go-spacemesh
causes network overload it may be hard to find out what kind of traffic is causing the problems. It would be nice to have some overview of the traffic even in case if the metrics are disabled. The current data transfer rates should be easy to view even without any Prometheus to dorate
calculations.Description
AdminService.PeerInfoStream
response is extended with new fields.This includes connection kind (relay / hole punching information, with
HPInbound
andHPOutbound
meaning inbound and out-bound hole-punching, respectively) and client/server request and transfer statistics. Also, it includes the data transfer rates (bytes/s) calculated over 10s and 1m periods.The peer records look like this (not using actual IPs or peer IDs):
The output of
spacemesh.v1.DebugService.NetworkInfo
now looks like:Test Plan
Tested on a mainnet node
TODO