Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ld warnings on macOS 13 builder #5892

Closed
wants to merge 4 commits into from
Closed

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Apr 26, 2024

Motivation

Description

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.6%. Comparing base (5f7d0df) to head (5213a18).
Report is 1 commits behind head on develop.

❗ Current head 5213a18 differs from pull request most recent head 196f3cb. Consider uploading reports for the commit 196f3cb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #5892   +/-   ##
=======================================
  Coverage     80.5%   80.6%           
=======================================
  Files          286     285    -1     
  Lines        29531   29512   -19     
=======================================
+ Hits         23795   23802    +7     
+ Misses        4138    4120   -18     
+ Partials      1598    1590    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu
Copy link
Contributor

poszu commented Apr 27, 2024

Recently the runner was changed, but the post library wasn't updated - it's built on a different MacOS version. Perhaps the warnings are caused by this?

I already updated the runner in post-rs too, but I haven't created a new release yet. How about trying with libpost built on macos-13 first?

@fasmat
Copy link
Member Author

fasmat commented Apr 27, 2024

Recently the runner was changed, but the post library wasn't updated - it's built on a different MacOS version. Perhaps the warnings are caused by this?

Maybe, but the previous runner was macos-12 and normally libraries built on older versions should work fine to use on a newer macOS.

I thought the warning fix would be a simple one line change of of the Makefile, but the fix broke the linux build and since it's not super urgent to get rid of the warnings I wasn't planning on continuing this for now.

@fasmat fasmat closed this May 21, 2024
@fasmat fasmat deleted the fix-ld-warnings-macos branch May 21, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants