Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - api: v2alpha1 transaction service #5933

Closed
wants to merge 14 commits into from

Conversation

kacpersaw
Copy link
Contributor

@kacpersaw kacpersaw commented May 13, 2024

Definition:

service TransactionService {
  rpc List(TransactionRequest) returns (TransactionList);
  rpc ParseTransaction(ParseTransactionRequest) returns (ParseTransactionResponse);
  rpc SubmitTransaction(SubmitTransactionRequest) returns (SubmitTransactionResponse);
  rpc EstimateGas(EstimateGasRequest) returns (EstimateGasResponse);
}

Stream will be implemented in separate PR

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 77.15134% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 80.7%. Comparing base (166e015) to head (cbc5aa7).
Report is 4 commits behind head on develop.

Files Patch % Lines
api/grpcserver/v2alpha1/transaction.go 73.2% 52 Missing and 18 partials ⚠️
sql/transactions/transactions.go 77.2% 3 Missing and 2 partials ⚠️
sql/builder/builder.go 93.1% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #5933     +/-   ##
=========================================
- Coverage     80.8%   80.7%   -0.1%     
=========================================
  Files          287     288      +1     
  Lines        29905   30232    +327     
=========================================
+ Hits         24182   24424    +242     
- Misses        4140    4202     +62     
- Partials      1583    1606     +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kacpersaw kacpersaw force-pushed the v2alpha1-transaction-service branch from 47f222a to 7215005 Compare May 14, 2024 12:18
@kacpersaw kacpersaw marked this pull request as ready for review May 22, 2024 07:11
sql/transactions/transactions.go Outdated Show resolved Hide resolved
api/grpcserver/v2alpha1/transaction.go Show resolved Hide resolved
api/grpcserver/v2alpha1/transaction.go Outdated Show resolved Hide resolved
@kacpersaw
Copy link
Contributor Author

bors merge

spacemesh-bors bot pushed a commit that referenced this pull request May 23, 2024
Definition:
```
service TransactionService {
  rpc List(TransactionRequest) returns (TransactionList);
  rpc ParseTransaction(ParseTransactionRequest) returns (ParseTransactionResponse);
  rpc SubmitTransaction(SubmitTransactionRequest) returns (SubmitTransactionResponse);
  rpc EstimateGas(EstimateGasRequest) returns (EstimateGasResponse);
}
```


Stream will be implemented in separate PR
@spacemesh-bors
Copy link

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title api: v2alpha1 transaction service [Merged by Bors] - api: v2alpha1 transaction service May 23, 2024
@spacemesh-bors spacemesh-bors bot closed this May 23, 2024
@spacemesh-bors spacemesh-bors bot deleted the v2alpha1-transaction-service branch May 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants