Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BEST-RQ implementation #2309

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Conversation

whettenr
Copy link

What does this PR do?

Adds an implementation of BEST-RQ.
Add layer dropout interface for transformer classes.
Add output hidden layers and wrappers to be able to run MP3S benchmarks.

Fixes #<issue_number>

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@whettenr whettenr changed the title Sync deletion BEST-RQ implementation Dec 19, 2023
@Adel-Moumen
Copy link
Collaborator

Hello @whettenr,

Thanks for this PR! We've recently merged in develop a lot of new PRs as part of SpeechBrain 1.0. Unfortunately, this PR as many conflicts due to the latests merge. Do you mind updating your fork and fix all the potential conflicts ? Thanks.

Best,
Adel

@whettenr
Copy link
Author

Hey @Adel-Moumen,
Yes I will work on this! Thanks!
Ryan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants