Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interfaces.py #2323

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

id-yananzhao
Copy link

@id-yananzhao id-yananzhao commented Jan 4, 2024

What does this PR do?

let user overwrite the hardcoding savedir in pretrained.fetching.fetch function. The fetch function always creates pretrained_model_checkpoints in the root directory of the code and it can be a problem for some read-only system settings, e.g. AWS Lambda. No major changes except having the **kwarg passing around.

Fixes #<issue_number>

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

let user overwrite the hardcoding savedir
@Adel-Moumen
Copy link
Collaborator

Could you please have a look @Gastron ? Thanks !

@Adel-Moumen Adel-Moumen added the enhancement New feature or request label Jan 17, 2024
@TParcollet
Copy link
Collaborator

@Adel-Moumen this looks like an ontology that we do not want to apply only on this class/function but rather across the interface. We should keep it on a "todo" list for inferences changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants