Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP french dataset #2459

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

pchampio
Copy link
Contributor

@pchampio pchampio commented Mar 12, 2024

LM done

What does this PR do?

Add recipe for common french elra datasets

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@pchampio pchampio force-pushed the new_recipe_ESTER+EPAC+ETAPE+REPERE branch 2 times, most recently from 50eb05e to 6348a56 Compare March 12, 2024 18:23
@pchampio pchampio force-pushed the new_recipe_ESTER+EPAC+ETAPE+REPERE branch 4 times, most recently from 0f03caf to b350fad Compare April 19, 2024 15:46
@asumagic asumagic self-assigned this May 15, 2024
@asumagic asumagic self-requested a review May 15, 2024 12:04
Squashed commits from pchampio to avoid storing HF model junk in the repository
(still have a backup of the branch somewhere)
@asumagic asumagic force-pushed the new_recipe_ESTER+EPAC+ETAPE+REPERE branch from 97a0252 to fccb474 Compare May 16, 2024 13:35
@asumagic
Copy link
Collaborator

Squashed the commit into one so that the removed pretrained HF model stuff doesn't make it to the history; looking into the other CI issues (which seems to be because of old yaml that breaks due to the changes in the train scripts) and will try to test soon

This seemed to be removed with the assumption that it was unused, but some yaml scripts in the trunk actually relies on it. Since this doesn't actually do anything if the hparams is specified, include it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants