-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests/samples
to HF?
#2513
base: develop
Are you sure you want to change the base?
Conversation
4f62ce3
to
eb8e078
Compare
The PR seems to work in my testing. Needs more discussion to see if people are OK with this. Then, we will need migrating that new repo under the |
This is only for recipe PRs that add data to the test samples right? And the change to the process is simply to open a concurrent PR to the HF test samples repo right? |
Correct, but one problem that just occurred to me is that we need to think about the flow for updating the submodule from a PR. Apparently, submodules allow tracking branches nowadays which might make sense here. |
What does this PR do?
WIP. Proof-of-concept of using a submodule towards HF using LFS, which has a few practical advantages:
The obvious downgrade is that it makes recipe PRs more annoying.
Before submitting
PR review
Reviewer checklist