Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refresh coupon_code order attribute #11734

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refresh coupon_code order attribute #11734

wants to merge 2 commits into from

Conversation

KacperMekarski
Copy link
Contributor

coupon_code attribute is currently memoized after removing promotion from order, it shouldn't.

@viezly
Copy link

viezly bot commented Jul 20, 2022 •
edited

Changes preview:

Legend:

👀 Review pull request on Viezly

@KacperMekarski
Copy link
Contributor Author

I think it should be merged before: #11733

@damianlegawiec
Copy link
Member

@KacperMekarski please sync with latest changes from main branch

@KacperMekarski
Copy link
Contributor Author

@damianlegawiec done.

@rafalcymerys rafalcymerys added this to the 4.5 milestone Sep 28, 2022
@rafalcymerys rafalcymerys modified the milestones: 4.5, 4.6 Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianlegawiec damianlegawiec Awaiting requested review from damianlegawiec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KacperMekarski @damianlegawiec @rafalcymerys