Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Country field position at checkout for no USA countries in address.rb #11745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

4goodapp
Copy link

@4goodapp 4goodapp commented Aug 9, 2022

See issue #11744 for more details.

@viezly
Copy link

viezly bot commented Aug 9, 2022

Changes preview:

Legend:

👀 Review pull request on Viezly

@4goodapp 4goodapp changed the title Update Country filed position at checkout for no USA country in address.rb Update Country field position at checkout for no USA country in address.rb Aug 9, 2022
@4goodapp 4goodapp changed the title Update Country field position at checkout for no USA country in address.rb Update Country field position at checkout for no USA countries in address.rb Aug 9, 2022
@rafalcymerys
Copy link
Member

@4goodapp looking at the overall structure of the updated form, wouldn't it also make sense to move zipcode after city?

@4goodapp
Copy link
Author

@4goodapp looking at the overall structure of the updated form, wouldn't it also make sense to move zipcode after city?

Not sure if it makes a difference but why not :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants