New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip args sanitizing for :for_template_promotion_id scope #12005

Open

mateus-po wants to merge 1 commit into main from fix/Ransack-incorrectly-converts-scope-argumets-to-boolean

Contributor

mateus-po commented Mar 1, 2024

The fix is related to this issue.

Ransack scope functions by default convert values that are included in those sets to pertinent boolean values:

    TRUE_VALUES = [true, 1, '1', 't', 'T', 'true', 'TRUE'].to_set
    FALSE_VALUES = [false, 0, '0', 'f', 'F', 'false', 'FALSE'].to_set

This is undesirable since integer 1 is correct value for :for_template_promotion_id and should be treated as such.

Setting self.ransackable_scopes_skip_sanitize_args prevents this conversion. It affects only true/false values conversion.


          skip args sanitizing for :for_template_promotion_id scope

mateus-po requested a review from rafalcymerys

March 1, 2024 12:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment