Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stripPrefix to be less strict about contextPaths #3009

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hildo
Copy link

@hildo hildo commented Jul 23, 2023

@spencergibb I was thinking about the issue #1935 .. would something like this be appropriate?

This is not complete, and tests would need to be added. But it would be convenient of users of StripPrefix (or additional filters) could dictate whether the strict validation should be enforced?

I know for the use case I am facing we don't need the context path enforced on the target service. But I am presuming that this was introduced for a reason. However, when I override this locally with a different filter (which is the same as StripPrefix but with the change in the PR hard coded), everything seems to work fine.

If you think there is merit here, I am happy to continue getting the tests to pass and adding in new tests. I just wanted to confirm with you whether this was a plausible solution. If so, I will try to get this into a mergeable state (in case I haven't been clear, this Pull Request is not in a mergeable state).

Thanks

@pivotal-cla
Copy link

@hildo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@hildo Thank you for signing the Contributor License Agreement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants