Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for org.testcontainers.kafka.KafkaContainer #40695

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eddumelendez
Copy link
Contributor

Testcontainers 1.19.8 provides org.testcontainers.kafka.KafkaContainer, which relies on apache/kafka image.

Testcontainers 1.19.8 provides `org.testcontainers.kafka.KafkaContainer`,
which relies on `apache/kafka` image.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 11, 2024
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels May 13, 2024
@wilkinsona wilkinsona added this to the 3.4.x milestone May 13, 2024
@wilkinsona
Copy link
Member

Thanks, @eddumelendez. A few notes and things for us to think about prior to merging this (plenty of time as this is just too late for 3.3 unfortunately):

  • Should we rename our existing KafkaContainerConnectionDetailsFactory to ConfluentKafkaContainerConnectionDetailsFactory, and similar for the existing KafkaContainerConnectionDetails?
  • Should we rename org.springframework.boot.testsupport.testcontainers.DockerImageNames.kafka()?

In addition to these, we'll also need to do something about the docs. When we upgrade to Testcontainers 1.19.8, "Containers of type KafkaContainer" will become ambiguous as there will be two types named KafkaContainer. I've opened #40699 for that. We'll then need to make some further changes here so that it's clear that both KafkaContainer types are supported.

@eddumelendez
Copy link
Contributor Author

Hi @wilkinsona,

Should we rename our existing KafkaContainerConnectionDetailsFactory to ConfluentKafkaContainerConnectionDetailsFactory, and similar for the existing KafkaContainerConnectionDetails?

We are planning to deprecate the existing one under org.testcontainers.container.KafkaContainer and provide a Confluent module with org.testcontainers.confluent.KafkaContainer. So, with those changes I think we can add a new ConfluentKafkaContainerConnectionDetailsFactory and ConfluentKafkaContainerConnectionDetails when available and deprecate existing Kafka* implementations in SB.

Should we rename org.springframework.boot.testsupport.testcontainers.DockerImageNames.kafka()?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants