Make sure swagger is working with SwaggerRsource containing full URL #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR @ouaibsky. Have you tested this in an ALB scenario with x-forward headers set? |
|
It has been tested with spring gateway |
|
@dilipkrish it's been over 14 months since this regression was reported, and nearly a year now since this fix was proposed. Any update on when we can expect this fix to be released? This is of pretty high impact as it completely breaks the ability of springfox to respect external URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fix issue #3413
It was working in swagger 2.x.y
It's mandatory when you aggregate many swagger resources (remote services) into one service with a unique swagger-ui (like api gateway)
Christophe