PR: Fix setting user environment variables on Windows #22075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I encountered another issue when investigating this. When removing an environment variable, it is not removed from the registry. I think some discussion and more work would be required to fix this issue, since this requires more than just over-writing existing variables. Also related may be #3891. |
…fine a `CONF_SECTION` class attribute! Hint: <spyder.widgets.collectionseditor.CollectionsEditorWidget object at 0x0000021679642320> or its parent should define the section."
…ype." When inserting new variable in user environment variables on Windows, the value may not be a string and results in the error above.
ccordoba12
reviewed
May 18, 2024
There was a problem hiding this comment.
Thanks for your help with this @mrclary! Just a clarifying suggestion for you, the rest looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
ccordoba12
approved these changes
May 20, 2024
There was a problem hiding this comment.
Thanks @mrclary!
Note: The failure in our tests is unrelated to this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When adding user environment variables to Windows registry, the value must be a string. Under some circumstances, the user provided value may be numeric resulting in
ValueError: Could not convert the data to the specified type.. Applyingclean_envresolves this issue.Also, a user warning
UserWarning: A SpyderConfigurationObserver must define a `CONF_SECTION` class attribute!was encountered when launching the User environment variable widget. This was fixed by addingCONF_SECTION = 'main'to theCollectionsEditorWidgetclass.Issue(s) Resolved
Fixes #21771
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: