Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fix detecting Matplotlib backend for its 3.9.0 version (IPython console) #22100

Merged
merged 1 commit into from
May 22, 2024
Merged

PR: Fix detecting Matplotlib backend for its 3.9.0 version (IPython console) #22100

merged 1 commit into from
May 22, 2024

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented May 20, 2024 •
edited by ccordoba12

Description of Changes

@pep8speaks
Copy link

pep8speaks commented May 20, 2024 •
edited

Hello @mrclary! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-05-22 21:19:54 UTC

@mrclary mrclary changed the title PR: Accommodate Matplotlib 3.9.0 PR: Accommodate Matplotlib 3.9.0 in spyder-kernels 2.x May 20, 2024
@mrclary mrclary marked this pull request as ready for review May 20, 2024 18:50
@mrclary mrclary self-assigned this May 20, 2024
@mrclary mrclary requested a review from ccordoba12 May 20, 2024 18:51
@mrclary mrclary marked this pull request as draft May 20, 2024 19:29
@ccordoba12 ccordoba12 changed the title PR: Accommodate Matplotlib 3.9.0 in spyder-kernels 2.x PR: Fix detecting Matplotlib backend for its 3.9.0 version May 22, 2024
@ccordoba12 ccordoba12 added this to the v5.5.5 milestone May 22, 2024
@ccordoba12 ccordoba12 changed the title PR: Fix detecting Matplotlib backend for its 3.9.0 version PR: Fix detecting Matplotlib backend for its 3.9.0 version (IPython console) May 22, 2024
@ccordoba12
Copy link
Member

@mrclary, please resync our Spyder-kernels subrepo to merge this one.

@ccordoba12 ccordoba12 mentioned this pull request May 22, 2024
Closed
@mrclary mrclary marked this pull request as ready for review May 22, 2024 16:08
@mrclary
git subrepo pull (merge) --branch=2.x --remote=https://github.com/spy…
acddb49 
…der-ide/spyder-kernels.git --update external-deps/spyder-kernels

subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "3ca2930b5"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "2.x"
  commit:   "3ca2930b5"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
ccordoba12
ccordoba12 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary for your help with this!

@ccordoba12 ccordoba12 merged commit b6ca9d0 into spyder-ide:5.x May 22, 2024
23 checks passed
ccordoba12 added a commit that referenced this pull request May 22, 2024
@ccordoba12
Merge from 5.x: PR #22100
fa02a67
@mrclary mrclary deleted the mpl390 branch May 22, 2024 22:30
@ccordoba12 ccordoba12 mentioned this pull request May 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@mrclary mrclary

Labels
component:IPython Console type:Bug
Projects
None yet
Milestone
v5.5.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrclary @pep8speaks @ccordoba12