Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes configuration example #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grewhit25
Copy link

This is a basic configuration file for kubernetes.

Created top level directory examples # other examples could be placed here
Configuration and README file placed in examples directory
Top level README updated pointing to config file.

Advanced users may wish to implement ingress instead of a nodePort and also possibly removing the need for a sidecar.

Copy link
Contributor

@gcampax gcampax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for preparing this, it's super helpful! I have a couple suggestions inline.

More generally, did you have a chance to test this with the master version of almond-server?

- name: TZ
value: Europe/London
- name: THINGENGINE_HOST_BASED_AUTHENTICATION
value: local-ip
Copy link
Contributor

@gcampax gcampax Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be proxied-ip and should you set THINGENGINE_HAS_REVERSE_PROXY?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback.
I haven’t tested against the latest master; but I will and investigate your suggestions above.

I am running almond on an arm64 based platform so will need to recompile.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have now build an arm64 image from the latest master branch and tagged it 1.99.0.
However, could you point me in the direction of where, for example; THINGENGINE_HOST_BASED_AUTHENTICATION and THINGENGINE_HAS_REVERSE_PROXY are defined so that I can carry out some further tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are defined/used in config.js

proxy_http_version 1.1;
proxy_set_header Upgrade $http_upgrade;
proxy_set_header Connection $connection_upgrade;
proxy_set_header Host "127.0.0.1:3000";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this might confuse the logic to compute the right redirect URLs for OAuth. DId you try with any OAuth skill (such as Spotify)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment; will investigate and report back.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed setting the header in that way dose confuse the logic because when you try to configure Spotify for example although you are presented with your Spotify account login page, the end result is: ‘ cannot open page because it cannot connet to the server’. More ideas needed.
But isn’t this a restriction on the local almond server or have there been some other changes since 1.8.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been changes here as we try to make the experience smoother for users of the Home Assistant add-on. I additionally changed how we check for host-based authentication and how the origin check works, in a way that should make this hack less necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants