Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Fix issues with pandas 3 #9245

Merged
merged 2 commits into from
May 14, 2024
Merged

Conversation

bashtage
Copy link
Member

Start to address issues with read-only arrays
Fix other warnings from pandas 3

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

Start to address issues with read-only arrays
Fix other warnings from pandas 3
@josef-pkt
Copy link
Member

are the axis keywords x.sum(axis=1) also required for numpy?
or are these for cases where both pandas and numpy might be used.

@bashtage
Copy link
Member Author

They are optional for NumPy but required for pandas.

@bashtage bashtage merged commit ba1ffab into statsmodels:main May 14, 2024
7 checks passed
@bashtage bashtage deleted the pandas-3-compat branch May 14, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants