Address input fixes #20005
Merged
Address input fixes #20005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
commented
May 14, 2024
Comment on lines
-135
to
+136
| (when (or (= status :default) | ||
| (= status :active)) | ||
| (when (empty? value) |
There was a problem hiding this comment.
First fix (paste button)
OmarBasem
commented
May 14, 2024
Comment on lines
-157
to
+159
| (when (= status :typing) | ||
| (when (or (= status :typing) | ||
| (and (= status :active) | ||
| (not-empty value))) |
There was a problem hiding this comment.
Second fix (X button)
OmarBasem
commented
May 14, 2024
Comment on lines
170
to
174
| (when (and (= status :loading) valid-ens-or-address?) | ||
| (when (and (or (= status :loading) | ||
| (= status :default)) | ||
| valid-ens-or-address?) |
There was a problem hiding this comment.
Third fix (checkmark)
OmarBasem
requested review from
seanstrom,
vkjr,
smohamedjavid,
J-Son89 and
briansztamfater
Jenkins BuildsClick to see older builds (8)
|
OmarBasem
requested review from
a team,
J-Son89,
briansztamfater and
ulisesmac
and removed request for
J-Son89 and
briansztamfater
ulisesmac
approved these changes
May 15, 2024
J-Son89
approved these changes
May 15, 2024
briansztamfater
approved these changes
May 15, 2024
smohamedjavid
approved these changes
May 16, 2024
67% of end-end tests have passedFailed tests (15)Click to expandClass TestWalletMultipleDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestDeepLinksOneDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (35)Click to expandClass TestWalletOneDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePRTwo:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
mariia-skrypnyk
force-pushed
the
fix/paste-button
branch
from
b222c74
to
d43dc61
Compare
80% of end-end tests have passedFailed tests (3)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Passed tests (12)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestDeepLinksOneDevice:
|
|
Hi @OmarBasem ! But here are some Android issues👇 ISSUE 1: cross icon doesn't delete entered address on Send to screen Steps:
Expected result: data is deleted successfully, Past and scan icons appeared video_2024-05-17_16-21-46.mp4 |
OmarBasem
force-pushed
the
fix/paste-button
branch
from
d43dc61
to
159b936
Compare
|
Thanks for your testing @mariia-skrypnyk! Fixed the issue. |
85% of end-end tests have passedFailed tests (6)Click to expandClass TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (44)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
|
|
Hi @OmarBasem ! Thanks for handling this issue 🙌! Failed e2e are not related, please go ahead and do the merge! |
OmarBasem
force-pushed
the
fix/paste-button
branch
from
159b936
to
5d80aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #19427, #20014
Summary
This PR fixes 3 issues with the address input:
Demo
Screen_Recording_20240514_091651_Status.mp4