Add Opencv Calibration File parameter to zedsrc element #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n calibration file path
|
Thank you for this feature. Please read my comments and apply the simple fixes, then I will merge it |
Hi @Myzhar, I don't see your comments. Where are they? |
|
They are in the review of the Pull Request |
@Myzhar sorry to have to follow up again, but I don't see any reviews on my end for this PR. This is what I see:
|
Myzhar
reviewed
Apr 24, 2024
|
@jdcast I'm sorry, I did not submit the review |
|
@Myzhar I've made the changes you requested. |
|
Hi @Myzhar just pinging you on this before it goes stale. |
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the zedsrc gstreamer element to be called with a parameter for loading a opencv calibration file:
optional-opencv-calibration-file.