Added proper errors handling for config and fixed multiple logger instances being created

[rohittp0]

Changes

• Fixed multiple logger instances being created for a single log output file
• Updated the route_logger to directly access logger instead of requiring an additional parameter
• Added proper error message with possible fix for missing / incorrect config.toml
• Added warning and steps to fix for missing optional key in config.toml
• Added exit with error for missing required keys

Missing Key

Before

Traceback (most recent call last):
  File "/Users/rohit/Data/Other/devika/devika.py", line 227, in <module>
    init_devika()
  File "/Users/rohit/Data/Other/devika/src/init.py", line 11, in init_devika
    sqlite_db = config.get_sqlite_db()
                ^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/rohit/Data/Other/devika/src/config.py", line 44, in get_sqlite_db
    return environ.get("SQLITE_DB_PATH", self.config["STORAGE"]["SQLITE_DB"])
                                         ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
KeyError: 'SQLITE_DB'

After

24.03.28 22:34:11: root: ERROR  : Key 'SQLITE_DB' of STORAGE.SQLITE_DB not found in config.toml using 'None' as default value
24.03.28 22:34:11: root: INFO   : To fix this, update 'config.toml' with

[STORAGE]
SQLITE_DB = "Some value"

Missing config.toml

Before

Traceback (most recent call last):
  File "/Users/rohit/Data/Other/devika/devika.py", line 16, in <module>
    from src.agents import Agent
  File "/Users/rohit/Data/Other/devika/src/agents/__init__.py", line 1, in <module>
    from .agent import Agent
  File "/Users/rohit/Data/Other/devika/src/agents/agent.py", line 1, in <module>
    from .planner import Planner
  File "/Users/rohit/Data/Other/devika/src/agents/planner/__init__.py", line 1, in <module>
    from .planner import Planner
  File "/Users/rohit/Data/Other/devika/src/agents/planner/planner.py", line 3, in <module>
    from src.llm import LLM
  File "/Users/rohit/Data/Other/devika/src/llm/__init__.py", line 1, in <module>
    from .llm import LLM
  File "/Users/rohit/Data/Other/devika/src/llm/llm.py", line 4, in <module>
    from .ollama_client import Ollama
  File "/Users/rohit/Data/Other/devika/src/llm/ollama_client.py", line 7, in <module>
    logger = Logger()
             ^^^^^^^^
  File "/Users/rohit/Data/Other/devika/src/logger.py", line 10, in __init__
    config = Config()
             ^^^^^^^^
  File "/Users/rohit/Data/Other/devika/src/config.py", line 11, in __new__
    cls._instance.config = toml.load("config.toml")
                           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/rohit/Data/Other/devika/venv/lib/python3.11/site-packages/toml/decoder.py", line 133, in load
    with io.open(_getpath(f), encoding='utf-8') as ffile:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'config.toml'

Process finished with exit code 1

After

24.03.28 22:37:54: root: FATAL  : Configuration file '/Users/rohit/Data/Other/devika/config.toml' not found
24.03.28 22:37:54: root: INFO   : Did you forget to create 'config.toml' file at the project root ( /Users/rohit/Data/Other/devika )?
24.03.28 22:37:54: root: INFO   : Checkout 'config.example.toml' and https://toml.io/en/ for more information on TOML.

Process finished with exit code 1

[ARajgor]

fetch the latest changes and resolve the conflicts.

[rohittp0]

@ARajgor The conflicts has been resolved

[rohittp0]

@Israel-Laguan If the review is done, can this be merged? I can understand you must be very busy but conflicts are piling on as new commits are being pushed to the main branch. :)

[Israel-Laguan]

Yeah I think it can be merged, no problem from my side

[rohittp0]

@Israel-Laguan Can you merge it as I don't have write access

[ARajgor]

log path is fetch from config file. we are saving it in data/logs/

[rohittp0]

We can't fetch from config file here as it needs to handle the case when the config file is missing

[ARajgor]

sample.config

[rohittp0]

I think it would be better of we can avoid IO here as there won't be any way to handle any errors as not even the logging will be enabled. Like what if the user incorrectly edits the sample.config and there is some mistake.

If you are sure that this won't be a concern I can update the code.

[rohittp0]

Or if the user renamed config.example to config etc

[ARajgor]

also why creating new logger? just fetch from logger file and log it. so it will be in one file and simple

[rohittp0]

The logger will not be initialised at this point, importing here will cause cycling import

[rohittp0]

@Israel-Laguan any updates ?

[Israel-Laguan]

Bro I don't have write access either

[Israel-Laguan]

@ARajgor would be able to help