New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for the Config class #248
Open
fauneau
wants to merge
10
commits into
stitionai:main
Choose a base branch
from
fauneau:add-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−26
Open
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fd3d4ed
refactor config: replaced 'config.toml' by _CONFIG_FILE
fauneau b3d8747
test config: implement tests for Config class
fauneau 22e26e1
fix config: eliminate surperfluous file loading
fauneau 15f57ba
refactor: put the load config logic in a function
fauneau 6287bf1
refactor: rename save_config to dump_config
fauneau ee4dee9
fix: correct a test
fauneau 934ade1
refactor: add _SAMPLE_CONFIG_FILE to Config class
fauneau c9a1f9a
fix: change a few save_config to dump_config
fauneau 9f76f57
fix: rename a test to be clearer
fauneau 4236cbd
clean: remove unnecessary empty lines
fauneau File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
from src.config import Config | ||
import os | ||
import shutil | ||
from pytest import fixture | ||
|
||
|
||
class TestConfig: | ||
|
||
_TEST_CONFIG_FILE = "sample.config.toml" | ||
|
||
@fixture | ||
def setup(self): | ||
# Delete Config singleton | ||
Config._instance = None | ||
|
||
@fixture | ||
def patch_config(self, mocker, tmpdir): | ||
""" | ||
Patch the class Config | ||
Config._CONFIG_FILE is changed to a path towards a temporary file | ||
The temporary file is a copy of _TEST_CONFIG_FILE | ||
""" | ||
assert os.path.isfile(self._TEST_CONFIG_FILE) | ||
p = tmpdir | ||
p = shutil.copy(self._TEST_CONFIG_FILE, p) | ||
return mocker.patch("src.config.Config._CONFIG_FILE", p) | ||
|
||
@fixture | ||
def patch_load_config(self, mocker): | ||
""" | ||
Patch load_config in class Config | ||
The return value from load_config is changed to `{}` | ||
""" | ||
return mocker.patch("src.config.Config._load_config", return_value={}) | ||
|
||
def test_creation(self, setup, patch_config): | ||
assert Config() is not None | ||
|
||
def test_singleton(self, setup, patch_config): | ||
assert Config() == Config() | ||
|
||
def test_load_config_called_once_during_multiple_access(self, setup, patch_config, patch_load_config): | ||
Config(), Config(), Config(), Config(), Config() | ||
patch_load_config.assert_called_once() | ||
|
||
def test_dump_config_correctly_saves_config(self, setup, patch_config): | ||
# Read config from file and modify values | ||
Config().set_bing_api_key("10random_bing_key01") | ||
Config().set_logs_dir("10random_logs_dir01") | ||
# (as of March 28th, setters save to file) | ||
# Get the config that was written to file | ||
config_saved = Config().get_config() | ||
# Force loading of the config from the file by deleting singleton | ||
Config._instance = None | ||
# Get the config loaded from file | ||
config_loaded = Config().get_config() | ||
|
||
assert config_saved == config_loaded | ||
|
||
|
||
|
||
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT:
Delete extra lines