Fix - optimized UI dockerfile and removed unnecessary index.html file & Reduce docker image size from 1.4 GB to 176MB #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajakumar05032000
changed the title
|
are check with the latest commits is it working or not if the docker is working then merge right away |
|
I have re-tested with latest code changes and it works smoothly as expected. Can you guys review & merge it. Thanks! |
|
Mentioning #317 cause both are docker related. can you guys check your changes and tell me it's working with every scenario. Front-end backend no issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes :
-> Updated the UI docker file. Earlier UI docker image used to consume 1.42 GB, now optimised to consume 176 MB.
-> Used Multi-stage build ( following industry standards) to optimise space and performance.
-> Added necessary comments for easy understanding.
-> Removed unnecessary index.html file from static folder ( which will cause white blank screen, if app is build & preview ed rather than just running dev ).
-> Added nodejs adapter in svelete.config.js to accommodate smooth build process & deployment of UI.
Docker Image size reduction :
All the above mentioned changes are tested thoroughly & it is working smoothly as expected !
Thank you !