Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/v8 #538

Draft
wants to merge 114 commits into
base: next
Choose a base branch
from
Draft

feat/v8 #538

wants to merge 114 commits into from

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Jan 21, 2024

  • updated to be compatible with v8
  • new ui
  • ui components extracted to ui package
  • better hmr (story list updates live without reloads)

breaking:

  • new requirements
    • @gorhom/bottom-sheet, react-native-gesture-handler, react-native-reanimated, react-native-svg

todo:

  • new controls ui
  • currently on rn cli a react-native-url-polyfill is needed to not crash the app, need to track this down and fix

progress:

progress4apr.mp4

@dannyhw
Copy link
Member Author

dannyhw commented Jan 21, 2024

@SocketSecurity ignore-all

@dannyhw dannyhw changed the base branch from feat/v7 to next January 29, 2024 15:17
@vstlouis
Copy link

vstlouis commented Jun 8, 2024

Hey! Great work here. Just wondering what work is left to get v8 support and maybe offer assistance to move this along. Thanks!

@dannyhw
Copy link
Member Author

dannyhw commented Jun 9, 2024

@vstlouis Hey at this point its missing

  • Updated controls ui
  • maybe rework the bottom sheet
  • make the new ui work on web/wide screens
  • refactor theme, right now its a mix between old and new (copy of web theme). Instead should update anywhere that references old theme values.

Problem is I've had a lot going on in my personal/work life so haven't had any time to pick this up.

If you or anyone wants to have a go at bringing the controls ui closer to the web version of mobile ui or anything else listed then im happy to review prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants