feat: unlist core packages from plugin list #20266
Conversation
Marc-Roig
added
source: core:admin
| // List of core plugins that are always enabled, | ||
| // and so it's not necessary to display them in the plugins list | ||
| const CORE_PLUGINS = ['content-manager', 'content-type-builder', 'email', 'upload', 'i18n']; |
There was a problem hiding this comment.
I think the official term now is core packages
There was a problem hiding this comment.
shouldn't we rename everything in here "packages"? even the configuration references plugins, and it feels "off" to reference packages in this const variable but reference plugins in the rest of the controller.
|
Shouldn't review workflows and releases be delisted also? |
I was thinking the same, and releases is also only for EE editions... I know technically is always "installed" but doing nothing for CE edition but always felt weird for me show it when is really not doing anything |
Indeed yeah I agree, that code shouldn't even be loaded on CE to begin with. |
|
good point! will add those to the list |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| })); | ||
| // List of core plugins that are always enabled, | ||
| // and so it's not necessary to display them in the plugins list | ||
| const CORE_PLUGINS = [ |
There was a problem hiding this comment.
This list will need to be maintained with the same list as https://github.com/strapi/strapi/blob/v5/main/packages/core/core/src/loaders/plugins/get-enabled-plugins.ts shall we write that?
There was a problem hiding this comment.
good point, will add a comment
What does it do?
We were listing all internally installed plugins on the admin plugins page.
This PR removes the ones that are pre-installed for the user (core plugins), it was confusing as users were not able to uninstall them, or even see them listed in their "package.json" files.
Resolves: Content-722