Instant Debits: Polished the flow #3590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 build increased size, 3 builds decreased size, 2 builds had no size change
StripePaymentsUISize 1.0 (1)
|
| Item | Install Size Change |
|---|---|
| Other | ⬇️ -444 B |
View Treemap
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
No changes to report
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 444 B (-0.01%)
Total download size change: ⬇️ 83 B
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬇️ -444 B |
View Treemap
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 1.3 kB (0.01%)
Total download size change: ⬆️ 1.4 kB (0.04%)
Largest size changes
| Item | Install Size Change |
|---|---|
| StripePaymentSheet.PaymentSheetFormFactory.makeUSBankAccount(merc... | ⬆️ 1.2 kB |
| StripePaymentSheet.PaymentSheetFormFactory.makeInstantDebits | ⬆️ 588 B |
| Other | ⬇️ -408 B |
View Treemap
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
No changes to report
StripeSize 1.0 (1)
com.stripe.StripeSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 444 B
Total download size change: ⬇️ 63 B
Largest size changes
| Item | Install Size Change |
|---|---|
| Other | ⬇️ -444 B |
View Treemap
🛸 Powered by Emerge Tools
📸 Snapshot TestNo snapshots generated
🛸 Powered by Emerge Tools |
kgaidis-stripe
force-pushed
the
kg-instadeb-polish
branch
from
74a0684
to
41f65fd
Compare
kgaidis-stripe
force-pushed
the
kg-instadeb-polish
branch
from
41f65fd
to
af226c6
Compare
kgaidis-stripe
force-pushed
the
kg-instadeb-polish
branch
from
af226c6
to
95774ed
Compare
kgaidis-stripe
force-pushed
the
kg-instadeb-polish
branch
from
95774ed
to
bef0bd2
Compare
bric-stripe
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
^ small code polish around Instant Debits (both code and non-code)
Testing
Start Flow
End Flow