Fix for boostrap 5-style data- attributes. #4604
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for one additional line
Should resolve nodejs build errors
|
Hello... i have the same problem with the dropdowns. Do you know if this will be merged? |
|
Once @ninjanerdbgm fixes the commented outlined issues, then yes. For now, though, feel free to try the changes, and if you're able to fix it, create a PR, I'll check it, and merge if they work. |
r5574
reviewed
Apr 3, 2024
| @@ -175,8 +175,8 @@ const ui = function(editorOptions) { | |||
|
|
|||
| button: function($node, options) { | |||
| return renderer.create('<button type="button" class="note-btn btn btn-outline-secondary btn-sm" tabindex="-1">', function($node, options) { | |||
| if (options && options.data && options.data.toggle === 'dropdown') { | |||
| $node.removeAttr('data-toggle'); | |||
| if (options && options.data && options.data['bs-toggle'] === 'dropdown') { | |||
There was a problem hiding this comment.
I think this change is wrong. It needs to be
if (options && options.data && options.data['toggle'] === 'dropdown') {
otherwise it is still not working for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed "data-toggle" to "data-bs-toggle"
What does this PR do?
Currently, with bootstrap 5, the dropdown toggles do nothing when you click this. This PR fixes that.
Where should the reviewer start?
How should this be manually tested?