Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in IE9 compatible browser #4624 #4625

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

gnh1201
Copy link

@gnh1201 gnh1201 commented Mar 20, 2024

What does this PR do?

Where should the reviewer start?

  • src/js/core/env.js
    • When rendering the summernote editor in IE9 (IE9 compatible browser), $popover (or this.$popover) should not be null. (Based on summernote commit 1521019.)
    • The issue arose due to the lack of a join method in the CanvasPixelArray prototype, so I have added a check for this prototype.
  • src/js/module/Editor.js
    • When applying styles such as bold, underline, and italic in IE9 (IE9 compatible browser) there should be no errors. (Based on summernote version 0.8.18)

How should this be manually tested?

Any background context you want to provide?

  • This is a patch related to a browser that is compatible with IE9 specifications, not meant for general users but for industrial purposes. Unlike IE9 for general users, this browser is still in use for industrial applications, hence it's worth applying the patch.

What are the relevant tickets?

Screenshot (if for frontend)

image

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@DennisSuitters
Copy link
Member

Excellent, thank you for creating a PR, once I get a moment, I'll test the changes, and if all good do the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants