Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: replace vector syslog driver with docker logs #2061

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Mar 18, 2024

What kind of change does this PR introduce?

feature

What is the new behavior?

Attempts to use native docker logs driver.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner March 18, 2024 06:06
@coveralls
Copy link

coveralls commented Mar 19, 2024

Pull Request Test Coverage Report for Build 8354068508

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 16 of 36 (44.44%) changed or added relevant lines in 5 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 60.775%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/functions/download/download.go 0 2 0.0%
internal/start/start.go 10 28 35.71%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
internal/db/start/start.go 9 87.3%
Totals Coverage Status
Change from base Build 8337529316: -0.2%
Covered Lines: 5691
Relevant Lines: 9364

💛 - Coveralls

@sweatybridge sweatybridge changed the title feat: replace vector syslog driver with docker logs WIP: replace vector syslog driver with docker logs Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants