Fix fill color of checkbox icon #26125
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leonidk14 is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
leonidk14
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Ignored Deployments
|
MildTomato
requested changes
May 15, 2024
| @@ -170,7 +170,7 @@ | |||
| } | |||
|
|
|||
| [type='checkbox']:checked { | |||
| background-image: url("data:image/svg+xml,%3csvg viewBox='0 0 16 16' fill='black' xmlns='http://www.w3.org/2000/svg'%3e%3cpath d='M12.207 4.793a1 1 0 010 1.414l-5 5a1 1 0 01-1.414 0l-2-2a1 1 0 011.414-1.414L6.5 9.086l4.293-4.293a1 1 0 011.414 0z'/%3e%3c/svg%3e"); | |||
| background-image: url("data:image/svg+xml,%3csvg viewBox='0 0 16 16' fill='white' xmlns='http://www.w3.org/2000/svg'%3e%3cpath d='M12.207 4.793a1 1 0 010 1.414l-5 5a1 1 0 01-1.414 0l-2-2a1 1 0 011.414-1.414L6.5 9.086l4.293-4.293a1 1 0 011.414 0z'/%3e%3c/svg%3e"); | |||
There was a problem hiding this comment.
this will need to be fixed using CSS variables as we have multiple themes.
You can see the variables in use in these theme files.
Probably best to use background-control for the background on the checkbox, and foreground-default for the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
It fixes fill color of checkbox icon
What is the current behavior?
Right now both the background color of checkbox in checked state and fill color of the checkmark icon are black -> icon is not visible
What is the new behavior?
When the checkbox is checked the icon will be white