Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry to lib and core #3743

Closed
wants to merge 1 commit into from

Conversation

phughk
Copy link
Contributor

@phughk phughk commented Mar 21, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Debugging live queries and change feeds would benefit from telemetry.
Additionally, we should have telemetry in the other modules.

What does this change do?

Add telemetry

What is your testing strategy?

Local prometheus

Is this related to any issues?

Observability, LQ, CF

Does this change need documentation?

Have you read the Contributing Guidelines?

@phughk
Copy link
Contributor Author

phughk commented Mar 21, 2024

This is WIP. Primarily because it doesnt work. But secondarily because maybe the core engine should be exposing a trait for recording metrics. Then the network layer would provide a telemetry-loaded interface; Otherwise a no-op implementation can be passed down

@phughk
Copy link
Contributor Author

phughk commented May 21, 2024

Closing as this is something @AdoraNwodo is going to work on

@phughk phughk closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant