Add original value to Del in change feeds #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuel-keller
approved these changes
May 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mumoshu
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
Add a delete variant for change feeds that includes the original value
What does this change do?
Add a variant onto CF that includes the original value
What is your testing strategy?
integration, unit, manual
Usage tests will be implemented alongside LQ
live select diff ...and deleteIs this related to any issues?
Lq v2 del with diff/patch
Does this change need documentation?
Have you read the Contributing Guidelines?