New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nom, add recursion limits with arrays. #3975
Conversation
c45f0c2
to
958bd76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@DelSkayn clippy and tests are failing in the merge queue. Perhaps a new release of Rust? |
The clippy warning is indeed due to a new version of rust. The test is |
e8a8d16
f5d772d
to
e8a8d16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, happy to retick when ready
Co-authored-by: Tobie Morgan Hitchcock <tobie@surrealdb.com>
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation? & What does this change do?
This PR fixes a missed recursion limit with arrays.
Also completely removes any remaining usage of nom.
What is your testing strategy?
Added a test for ensuring that the array limit is upheld.
Is this related to any issues?
None
Does this change need documentation?
Have you read the Contributing Guidelines?