Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type::is::nil function #3989

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented May 6, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Add a simple way to check for nullable (not truthy) values.
Note: can be useful for building an ORM.

What does this change do?

Before:

WHERE (value != NONE AND value != null);

After:

WHERE !type::is::nil(value);

What is your testing strategy?

Unit tests

Is this related to any issues?

N/A

Does this change need documentation?

Have you read the Contributing Guidelines?

@Odonno Odonno requested review from a team and tobiemh as code owners May 6, 2024 16:44
@Odonno Odonno force-pushed the feat/is-nil-function branch 5 times, most recently from c58f255 to 6ba1341 Compare May 7, 2024 21:31
phughk
phughk previously approved these changes May 13, 2024
Copy link
Contributor

@phughk phughk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving these PRs, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants