Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query planner should evaluate non boolean expressions #4022

Merged
merged 7 commits into from May 14, 2024

Conversation

emmanuel-keller
Copy link
Contributor

@emmanuel-keller emmanuel-keller commented May 10, 2024

What is the motivation?

The query planner does not evaluate non boolean expressions. Therefore it can't trigger an execution plan that would include an index.

What does this change do?

The query planner correctly evaluates any part of the query that can be independently evaluated.

What is your testing strategy?

A test has been written.

Is this related to any issues?

Fixes #3950

Does this change need documentation?

  • No documentation needed

Have you read the Contributing Guidelines?

@emmanuel-keller emmanuel-keller changed the title Fixes #3950 Query planner should evalute non boolean expressions May 10, 2024
@emmanuel-keller emmanuel-keller changed the title Query planner should evalute non boolean expressions Query planner should evaluate non boolean expressions May 10, 2024
@emmanuel-keller emmanuel-keller marked this pull request as ready for review May 13, 2024 10:43
@emmanuel-keller emmanuel-keller requested review from a team and tobiemh as code owners May 13, 2024 10:43
@emmanuel-keller emmanuel-keller marked this pull request as draft May 13, 2024 11:05
@emmanuel-keller emmanuel-keller marked this pull request as ready for review May 13, 2024 11:21
Copy link
Contributor

@phughk phughk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

Copy link
Contributor

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmanuel-keller emmanuel-keller added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@emmanuel-keller emmanuel-keller added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 6277aab May 14, 2024
22 checks passed
@emmanuel-keller emmanuel-keller deleted the emmanuel/fixes-3950 branch May 14, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: No index is used when using time::now()
3 participants