Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results live filter prototype. #2921

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Search results live filter prototype. #2921

wants to merge 1 commit into from

Conversation

ihongda
Copy link
Contributor

@ihongda ihongda commented Dec 27, 2023

Related issues:
#2623
#2717

@ihongda ihongda linked an issue Dec 27, 2023 that may be closed by this pull request
12 tasks
@thesunshade
Copy link
Collaborator

thesunshade commented Feb 26, 2024

@ihongda I just realized I can checkout your branch and try this out using my local build. Amazing! Thank you for making this prototype.

This works very well to refine searches. I'm just wondering if we want to start out with a full on GUI for this, or if it should be more tightly integrated with the filter system.

@buddhist-uni, Have you tried this yet?

image

image

The branch is kind of out of date on other things, but it's very easy to test this specific feature.

image

@ihongda
Copy link
Contributor Author

ihongda commented Feb 28, 2024

Hmm, it's a prototype, there might be a better place to put these filters, like a top sheet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On larger search results, display a breakdown of what books the results are in
2 participants